Repository navigation
Set the default zprocess ProcessTree with set_default_process_tree() (needs zprocess 3) - #138
Open
chrisjbillington wants to merge 1 commit into
Open
chrisjbillington wants to merge 1 commit into
chrisjbillington wants to merge 1 commit into
Conversation
zprocess 3 no longer creates a default ProcessTree on import, and adds set_default_process_tree() to set the tree that zprocess.Event and zprocess.Process use when they are not given one. ProcessTree.instance() now calls it instead of assigning the private module attribute. This needs zprocess 3, and the dependency is to be raised when zprocess 3 is released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VtbtkgXgLhn7vtjucTrtLz
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet: this needs zprocess 3, which is not released yet. When it is, I'll add the change to the
zprocessrequirement to this PR.zprocess 3 no longer creates a default
ProcessTreeon import, and addszprocess.set_default_process_tree()to set one (chrisjbillington/zprocess#39). This PR uses that function instead of assigning the private attributezprocess.process_tree._default_process_tree.Nothing changes for users. Device code that calls
zprocess.Event(...)without a tree, such as the PulseBlaster BLACS worker, works as before.Testing: With this branch and chrisjbillington/zprocess#39, the zprocess tests passed, and an end-to-end test that installs the suite, compiles the example experiment, loads the shot in lyse and runviewer, and starts BLACS, runmanager, runviewer and lyse, passed on Ubuntu and Windows for Python 3.11 to 3.14 with PySide6, PyQt6 and PyQt5.
馃 Generated with Claude Code
https://claude.ai/code/session_01VtbtkgXgLhn7vtjucTrtLz