Repository navigation
Conversation
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Probe Podman through its API service, bound each runtime check to five seconds, and run default probes concurrently. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Isolate PATH, verify Podman remote-service arguments, cover mixed runtime health, and assert concurrent five-second probe bounds. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
|
Label |
This was referenced Sep 30, 2026
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Reject unrelated Podman remotes by resolving the same host-local Unix API socket used by the Podman driver, while keeping the total probe budget bounded. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Replace the generic remote-service assertion with local-socket discovery coverage and a regression for unrelated SSH remotes. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
This was referenced Oct 16, 2026
Clear clippy::doc_markdown on existing runtime-doctor PR #4. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
kvnloo
added a commit
that referenced
this pull request
Oct 18, 2026
Sync existing PR #4 source into its CI-only workflow branch. Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the scoped NVIDIA#3694 runtime-doctor design on a fresh branch based on NVIDIA/OpenShell main at
b8ffe5244cb244a1d74a4a03d69afe3da07e5f08.Closes #5. Long-term shared discovery/diagnostic architecture is tracked separately in #6.
Behavior
openshell doctor check: probes installed Docker and Podman candidates concurrently; succeeds when at least one is ready.openshell doctor check --driver docker|podman: selected runtime is authoritative.docker info --format {{.ServerVersion}}readiness check.OPENSHELL_PODMAN_SOCKET->podman --url unix://... version --format {{.Server.Version}}podman --remote version --format {{.Server.Version}}OPENSHELL_PODMAN_SOCKETis rejected explicitly.Tests
Deterministic fake-runtime coverage includes:
--driver--urlAlso adds a real
e2e-podmandoctor test against the harness-exportedOPENSHELL_PODMAN_SOCKET.GitHub Actions validation
The fork inherits NVIDIA workflows that depend on NVIDIA self-hosted runner labels, so those jobs cannot provide a complete fork-side signal. A validation-only
pull-request/4mirror runs the relevant checks on GitHub-hostedubuntu-latestwithout adding CI-only files to this PR.Current validation includes:
cargo fmt --all -- --checkcargo check -p openshell-clicargo build -p openshell-clidocker_preflightdoctor matrixValidation run: https://github.com/kvnloo/OpenShell/actions/runs/36690027304
References
openshell doctor checkNVIDIA/OpenShell#3694Draft until the full validation lane is green and the final architecture audit is complete.
October 18 exact-head Clippy remediation
feat/3694-runtime-probe-hardening,ee45fa8dfixes the exactclippy::doc_markdownfinding: backticks aroundOpenShellin socket discovery Rustdoc. The changed source blob7c4fa2d0was read back from GitHub; only that one-line source change was introduced by this commit.ae6571f:Clippy affected cratesFAILED, CLI/unit/doctor matrix SKIPPED; real Podman service probe PASSED. This is historical, not fresh evidence for the repaired head.pull-request/4branch advanced non-force tobaeb4ea0, merging the corrected source while preserving.github/workflows/fork-doctor-validation.ymlunchanged. API returned no new run for that head; hosted Clippy/CLI/E2E remain NOT RUN, not green. The execution container has no Cargo toolchain.any healthy runtimefallback can pass healthy Docker with a broken configured Podman. This must be resolved or explicitly agreed before origin publication. Draft origin #3970 is a separate Docker doctor-provider redesign (author: elezar); coordinate rather than duplicate.Status: CHECK / CI + requirement gap. No upstream publication or merge authorization asserted; DCO/vouch, required CI, and maintainer adoption remain separate gates.