[sahilkhatri09]

What type of PR is this?
/kind bug

What this PR does / why we need it:
The API server can close the exec WebSocket immediately after sending the exit status on the status channel (stream 3). When the status arrives, ExecProcess closes its own side, and writing that close frame can then fail with java.net.SocketException: Connection or outbound has been closed (thrown from WebSocketWriter.writeClose). failure() then unconditionally overwrote the already received exit status with -1975219. As a result, a command that finished, usually with exit code 0, was intermittently reported as failed. Callers can't tell this apart from a real mid-command disconnect, so they have to re-run commands that may not be idempotent.

This change only sets -1975219 when no exit status was received (statusCode < 0). A failure before the status arrives behaves exactly as before. The onUnhandledError callback is still invoked in both cases.

Which issue(s) this PR fixes:
Fixes #1891 (also reported in #1346, #3385, #4812)

Tests:
Added ExecTest.unhandledErrorAfterExitStatusKeepsExitCode, parameterized for exit codes 0 and 126. It delivers a status frame and then calls failure(). It fails without this change (exit value -1975219) and passes with it. ExecTest passes (13 tests), and spotless:check passes.

Does this PR introduce a user-facing change?

Exec: a connection failure after the exit status was received no longer overwrites the exit code with -1975219.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sahilkhatri09 / name: Sahil Khatri (589286f)

[kubernetes-prow]

Welcome @sahilkhatri09!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

/lgtm
/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, sahilkhatri09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment