Repository navigation
Fix and expand manual tests with auth repo - #403
Closed
rocketraman wants to merge 1 commit into
Closed
rocketraman wants to merge 1 commit into
rocketraman wants to merge 1 commit into
Conversation
Author
|
Closing, will submit a single PR with all related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual tests for an authenticated repo were not complete.
Fixed the test artifactory server startup.
Added a test for environment variable substitution (test 4). Note that this test follows the current documentation in the README of using
{{FOO}}style env var substitutions, but that will not currently work. What will work is$FOO. This should be updated as part of the fix for #402.Added a test for environment variable substitution with packaging (test 5). This test will not currently work as the substituted credentials are not passed to Gradle properly by kscript.
NOTE: Instead of this being a manual test, it could be done in an automated unit test with Testcontainers.