Repository navigation
Implement --add-bootstrap-header - #199
Merged
Merged
Conversation
See the added section in README.md for details
Test Plan:
- test/test_suite.sh
- rm -rf ~/.sdkman && echo 'println("Hello world")' > /tmp/s && kscript --add-bootstrap-header /tmp/s && /tmp/s
Collaborator
|
Imho the most beautiful PR in this repo until now. Adding a cool new feature, technically well done, including great tests and even documentation. Thanks a lot @EugeneSusla ! |
|
Sorry for being late, but I noticed an external script is used with curl https://github.com/holgerbrandl/kscript/blob/4dabdd729f5c0706ab04343dc6a0b0dd77d27bf7/src/main/kotlin/kscript/app/Kscript.kt#L70 Would it be better to keep all logic together in this repo? |
holgerbrandl
added a commit
that referenced
this pull request
Dec 14, 2018
Collaborator
|
Shame on me as a repo-maintainer for not spotting it in the first place. Thanks for pointing me to the problem. I've fixed it in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #195
See the added section in README.md for details
Test Plan: