Repository navigation
cygwin support improvements - #175
Conversation
|
Looks like a great PR, thanks for contributing. Could you merge-in my typo fix of the build-file, to make sure that the tests are still fine. |
- quote paths containing windows path separator '\' that was causing escaping characters in cygwin - use invariant separator '/' when generating gradle file for '--package'
18ad816 to
8e272a0
Compare
|
Hi @holgerbrandl sure it's done. 3 tests are failing. But those tests are failing for me on master locally even without any changes. Could you have a look at those 3 tests? Thanks |
… already supports 'reallyExecutable'
|
I've adjusted the tests to cope with the additional quoting in a separate branch pr175 (see link above in this thread). I've also merged in PR although I realized afterwards, that it seems to break the packaging by not setting the executable flag on the packaged script. See https://travis-ci.org/holgerbrandl/kscript/builds/442050672 |
|
You are right, I also noticed yesterday, but forgot to fix it. Can you please just change
to:
|
|
All tests are green again. :-) Thanks for contributing to kscript! |
Currently kscript is not working on Windows in cygwin.
Most of the issues were caused by not quoting paths containing windows path separator '' that was actually escaping characters in cygwin.
The '--package' didn't work for similar reason. In the generated gradle build file the actual script was added with windows path separators ''. Now using invariant separator '/'.