Skip to content

fix: resolve vite 8.1.5, tldts 7.0.16, and ws 6.2.3 - #1135

Merged
cjbell merged 1 commit into
mainfrom
cjbell-bc-05fcf1c2-753b-40a8-81fe-a8e3a35f6347-fb10
Nov 21, 2026
Merged

cjbell merged 1 commit into
mainfrom
cjbell-bc-05fcf1c2-753b-40a8-81fe-a8e3a35f6347-fb10

Conversation

@cursor

@cursor cursor Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Description

The 2026-11-21 Vanta scan of the javascript repository reports five open findings. This PR patches the three that have a release inside the ranges already requested.

  • vite 8.1.5 → 8.1.7 — AIKIDO-2026-137384 (critical). The dev server can evaluate an injected module id when it is exposed on the network. 8.1.7 includes the Rolldown 1.1.7 fix and stays on the 8.1 line. KNO-17048
  • tldts 7.0.16 → 7.5.5 — AIKIDO-2026-453894 (medium). Public suffix matching is wrong when a wildcard shares a label with a longer rule. tough-cookie@6.0.2 requests ^7.0.5, and 7.5.5 is inside that range. KNO-17049
  • ws 6.2.3 → 6.2.7 — AIKIDO-2026-844803 (low). A peer can exhaust memory by flooding Ping frames. react-native@0.79.2 requests ^6.2.3. The 7.x and 8.x copies are already on 7.5.14 and 8.23.0. KNO-17050

Two findings stay open because there is still no compatible upgrade:

  • minimatch 10.2.6 — CVE-2026-118764 (high). There is no 10.x release after 10.2.6. Minimatch 11 changes glob matching, and Expo declined that upgrade for @expo/fingerprint. KNO-16440
  • yargs 17.7.2 — AIKIDO-2026-922647 (low). 17.7.3 does not include the prototype-pollution fix, and yargs 18 is ESM-only. Metro still calls require("yargs"). KNO-16335

yarn vitest run --config=./vitest/config.ts packages/client passed: 23 files, 698 tests.

Checklist

  • Existing client unit tests were run against the patched Vite. No new tests were added; this only pins transitive versions inside existing ranges.

Screenshots or videos

Not applicable.

Open in Web View Automation 

Pin the versions Vanta reports as fixable inside the ranges already requested.

Co-authored-by: Chris Bell <chris@cjbell.co>
@cursor
cursor Bot requested a review from a team as a code owner November 21, 2026 21:32
@cursor
cursor Bot requested review from MikeCarbone, andy-knock, kylemcd, mattmikolay, meryldakin and thomaswhyyou and removed request for a team November 21, 2026 21:32
@changeset-bot

changeset-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: da0324e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
javascript-ms-teams-connect-example Ready Ready Preview Nov 21, 2026 9:35pm UTC
javascript-nextjs-example Ready Ready Preview Nov 21, 2026 9:35pm UTC
javascript-slack-connect-example Ready Ready Preview Nov 21, 2026 9:35pm UTC
javascript-slack-kit-example Ready Ready Preview Nov 21, 2026 9:35pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

KNO-17048

KNO-17050

KNO-17049

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit da0324e. Configure here.

Comment thread package.json
"uuid@npm:^7.0.3": "11.1.1",
"vite@npm:^6.0.0 || ^7.0.0 || ^8.0.0": "8.1.7",
"vite@npm:^8.1.5": "8.1.7",
"ws@npm:^6.2.3": "6.2.7",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset for security pins

Medium Severity

This PR adds root Yarn resolutions for vite, tldts, and ws and updates yarn.lock without a new .changeset file. Same-major security pins on root resolutions or the lockfile need a patch changeset so the next @knocklabs/* release records them. The existing ws-7-5-14.md only covers the prior ws@^7 pin.

Fix in Cursor Fix in Web

Triggered by learned rule: Published package changes need a changeset

Reviewed by Cursor Bugbot for commit da0324e. Configure here.

@codecov

codecov Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.63%. Comparing base (32c7a03) to head (da0324e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         142      142           
  Lines        4540     4540           
  Branches     1319     1319           
=======================================
  Hits         3570     3570           
  Misses        873      873           
  Partials       97       97           

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not approve this PR because GitHub does not allow this automation to approve its own pull request. Human review is needed; no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not approve: GitHub rejects a self-approval on this PR, even though it meets the dependency-update bar (patch/minor Yarn pins with CI green). Human review is needed, and no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Depdency updates (control, switchboard, CLI, javascript, telegraph)

@cjbell
cjbell merged commit a0237b9 into main Nov 21, 2026
16 checks passed
@cjbell
cjbell deleted the cjbell-bc-05fcf1c2-753b-40a8-81fe-a8e3a35f6347-fb10 branch November 21, 2026 21:44

This branch was successfully deployed

4 active deployments
Preview – javascript-nextjs-example — da0324e6 Deployed Nov 21, 2026 by vercel[bot]
Preview – javascript-slack-kit-example — da0324e6 Deployed Nov 21, 2026 by vercel[bot]
Preview – javascript-slack-connect-example — da0324e6 Deployed Nov 21, 2026 by vercel[bot]
Preview – javascript-ms-teams-connect-example — da0324e6 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants