Skip to content

🐛 Find checksums file works with ARTIFACTS_TO_PUBLISH variable - #275

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
cardil:bugfix/publish-correct-files-to-gh
Feb 17, 2023
Merged

knative-prow[bot] merged 1 commit into
knative:mainfrom
cardil:bugfix/publish-correct-files-to-gh

Conversation

@cardil

@cardil cardil commented Feb 16, 2023 •

Copy link
Copy Markdown
Contributor

Changes

  • 🐛 Find checksums file works with ARTIFACTS_TO_PUBLISH variable

/kind bug

Fixes #272
Follow up to #268

@knative-prow knative-prow Bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 16, 2023
@knative-prow
knative-prow Bot requested review from krsna-m and psschwei February 16, 2023 14:10
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2023
@cardil

cardil commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

/cc @upodroid
/cc @kvmware
/cc @psschwei
/cc @evankanderson

@cardil

cardil commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.9

@knative-prow-robot

Copy link
Copy Markdown

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid upodroid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but what is the kn-event release script doing that is different from the other kn-* scripts?

/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@cardil

cardil commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

@upodroid: Not a blocker, but what is the kn-event release script doing that is different from the other kn-* scripts?

The kn-plugin-repo is unique in a couple of places. I often use it as a proving grounds for new development approaches.

A couple of differences from the top of my head:

  • it uses mostly the Go-native built tools (via magetasks), instead of bash scripts
  • have multiple go.mod files and a go.work
  • builds artifacts and a checksums file in build subdirectory

@evankanderson evankanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow

knative-prow Bot commented Feb 16, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, evankanderson, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cardil,evankanderson,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil

cardil commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

/hold cancel

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@knative-prow
knative-prow Bot merged commit f41894d into knative:main Feb 17, 2023
@knative-prow-robot

Copy link
Copy Markdown

@cardil: new pull request created: #276

Details

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
cardil deleted the bugfix/publish-correct-files-to-gh branch February 17, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The release script fails to publish proper checksums and their signatures

4 participants