Skip to content

Consider adding gh to prow test-image #409

New issue
New issue
Open
Open
Consider adding gh to prow test-image#409
Assignees
dsimansk

Description

@dsimansk
dsimansk
opened on Jan 16, 2025

As a follow-up to refactoring release script from hub to gh CLI tool.[1] We should consider installing the gh in Prow's test-image. It's a go based project so our go_run functions works well. But the release pace is a bit more frequent than for hub.
We could use debian's package to have at least almost latest version pre-installed.

/cc @dprotaso @upodroid @cardil

[1] https://github.com/knative/hack/pull/408/files#diff-8bc94a3006768345d17c827c0bb5840e6e4daee6de1c2b1ea672f53f162d171dR96

Activity

  1. dsimansk
    changed the title [-]Consider adding `gh` prow test-image[/-] [+]Consider adding `gh` to prow test-image[/+] on Jan 17, 2025

  2. dprotaso commented on Mar 7, 2025

    @dprotaso
    dprotaso
    on Mar 7, 2025
    Member

    I'm good with whatever

    /assign @dsimansk

  3. knative-prow
    assigned
    dsimansk
    on Mar 7, 2025

  4. cardil commented on Mar 13, 2025

    @cardil
    cardil
    on Mar 13, 2025
    Contributor

    Adding the following to the prow Dockerfile, should pre-cache the binary:

    RUN go run github.com/cli/cli/v2/cmd/gh@v2.65.0 --help > /dev/null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions