Repository navigation
Use kube-codegen.sh instead of generate-groups.sh when moving to k8s.io api 0.28+ #336
Description
As of k8s.io/code-generator@v0.28.0, the script generate-groups.sh is deprecated and we should move to using kube-codegen.sh
Activity
andrew-su commentedon Oct 12, 2023
Related: #335
cardil commentedon Aug 28, 2024
The Kube v0.30 removed the
generate-groups.shcontents, which in turn renders Knative code-generation broken.Knative already rolled to Kube v0.30, for example: knative/serving#15462, knative/eventing#8126, so this essentailly prevents changes to any Knative CRDs.
As discussed in the Productivity WG, I will create a generate-groups like tool in Knative ASAP, and notify Knative working groups on migration steps in all the Knative projects, that use code-gen.
/assign
/kind bug
matzew commentedon Aug 28, 2024
Thanks a lot, @cardil
cardil commentedon Sep 2, 2024
Some maintainers already started doing the migration to kube_codegen.sh script:
And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.
We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ
/close
knative-prow commentedon Sep 2, 2024
@cardil: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.