Skip to content

.env options have no effect due to incorrect syntax #114

Open

Description

@geloescht

All options set by editing the .env file that is created by default have no effect whatsoever. The reason is, that the environment variables include semicolons at the end of each line. But config/custom-react-scripts/config.js expects the value "false" without a semicolon, thus enabling every single option if it finds "false;" instead.

BTW: webpack-dashboard seems to introduce serious memory leak issues. It took me ages to hunt these down, because I thought I had disabled the dashboard.

Activity

  1. jurosh commented on Nov 27, 2017

    @jurosh

    Got same performance issues, thanks god for your advice to remove semicolons.. I've created PR (#121) for this, so hope we can hot-fix this critical issue...

  2. m1n0s commented on Jan 22, 2018

    @m1n0s

    @geloescht thanks for your attention! 4 node.js processes had been killing my CPU.

  3. amadeogallardo commented on Jun 6, 2018

    @amadeogallardo

    @geloescht I can confirm the same behavior. Disabling Webpack Dashboard fixed the performance overhead issues and improved the hot reloading times considerably.

    The tradeoff was actually having to turn the AC heater on, instead of just using my notebook as a heater by frequently triggering a file change. In this case, it was quite literally a "hot reload".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions