Skip to content

Leverage plugin framework inside (test) catalog plugin  #55

Open

Description

@sbrossie

The current repo killbill-catalog-plugin-test is not using this repo as a base.

We should leverage all the new api POJOs (see #54) and stop pulling the classes from the killbill repo, i.e remove this dependency.

However, such dependency is also used to deserialize the XML catalog, by leveraging all the JAXB annotation. Perhaps instead we could use as a source JSON catalog files (see https://killbill.github.io/slate/#catalog-retrieve-the-catalog-as-json to extract such catalog json), and from the json data write a json parser leveraging jackson and the new api POJOs from this repo.

Activity

  1. sbrossie commented on Feb 25, 2022

    @sbrossie
    MemberAuthor

    Note that we could simplify the catalog plugin:

    1. Remove support for harcdoded large catalog
    2. As a start, check-in a json catalog in the resource, and use this.
  2. sbrossie commented on Apr 22, 2022

    @sbrossie
    MemberAuthor

    This work has been done as part of catalog-plugin-test PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions