Repository navigation
Conversation
Search commands always print JSON, but they rejected the -o flag that other commands accept, so scripts piping through jq got an error on stderr instead of JSON. Register the shared output flag on search, get, providers, and contents, and validate it before any request is sent.
chruffins
marked this pull request as ready for review
October 13, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel search,search get,search providers, andsearch contentsrejected-o jsonwithUnknown shorthand flag. Other commands accept it, and the search output is already JSON.-o/--outputflag on the four search commands. It acceptsjsonor nothing, and is validated before the request, so a bad value does not run a billable search.--content-max-charsrange (100–100000, default 10000) in the flag help and the README. The server enforces this range, so the CLI does not clamp.Testing
go test ./cmd/...passes. New cases cover-o jsonon get/providers/contents and invalid-o yamlon search, get, and contents, with no API call expected.Not in this PR
contents --requestwas never a CLI flag. The agent instructions that showed it are fixed separately in kernel/hypeship.