Repository navigation
feat(auth): add "press c to copy" for the device-login link - #772
Merged
Merged
Conversation
For user convenience, and inspired by the Claude Code workflow, add an opt-in way to copy the device-login link with "c". A hint prints under the panel. On "c" the link goes to the clipboard. The key read folds into the poll wait, so there is no background thread. The hint stays hidden off a terminal, under --json, or with no clipboard tool (pbcopy, clip, wl-copy, xclip, xsel, or clip.exe under WSL). No new dependency.
keboola-pr-reviewer-bot
approved these changes
Sep 16, 2026
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: auto_approve (risk 2/5) · profile keboola-mcp-server
Self-gated "press c to copy" UX affordance for the device-login URL, well-tested and auth control flow untouched.
This was referenced Sep 16, 2026
Closed
martinsifra
added a commit
that referenced
this pull request
Sep 17, 2026
Covers everything merged since v0.94.0: #768 (uv audit / uv >= 0.12.15), #772 (device-login "press c to copy") and #773 (test housekeeping). No `vNEXT` placeholders were outstanding (`make vnext-check` clean), and no `whatsnew.ts` entry is added -- nothing under `web/` changed this release, so the popup correctly has nothing new to show. gotchas.md: #772 reordered the device-login panel without updating the doc surface. The 0.92.0 "one-click link is conditional" gotcha quoted the old label ("Or open this link (code pre-filled):") and the old ordering, so a relay keying on either now picks the wrong line -- rewritten, plus a new entry for `press c to copy` being absent in exactly the situations an agent drives (`--json`, no TTY, no clipboard command). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
For user convenience, and inspired by the Claude Code workflow, add an option to copy the device-login verification link with
c.kbagent auth login(device flow) prints this URL for the user to open in a browser.What
Press c to copy the linkprints under the panel. Onc, the link goes to the clipboard and a green✓ Copied to clipboardline prints below it.--json, or with no clipboard tool. Backends:pbcopy,clip,wl-copy,xclip,xsel, orclip.exeunder WSL. No new dependency.Device login only.
serve --uiandlineage servercould follow, but they run inside a blocking server loop and would need a background thread, so the added comfort may not be worth it. Tests cover detection, the gate, and copy onc.