Skip to content

validate should not allow inline comments #32

Open

Description

@jjmschofield

As per:

"Invalid syntax includes inline comments and user or team names that do not exist on GitHub."

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

Activity

  1. AndersDJohnson commented on Nov 17, 2022

    @AndersDJohnson

    @jjmschofield Hey! Sorry to bother, but do we know if this is still the case as far as GitHub support goes? Recently noticed your github-codeowners tool was not able to parse a line like:

    my-file @my-owner # my comment
    

    with Error: # is not a valid codeowner name in rule

    But GitHub's new CODEOWNERS validation indicated it was ok... maybe not, didn't get around to testing if it still applied the rules...

    Happy to try to contribute a fix if you're open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions