feat(NewtonsoftJson): Upconvert from Case that should be a string #97

Activity

1. deviousasti commented on Jul 24, 2023

   

   deviousasti

   on Jul 24, 2023

   Member

   More actions

   What's the use-case? Someone might have persisted this to their DB without checking what it actually serializes as?
2. bartelink commented on Jul 24, 2023

   

   bartelink

   on Jul 24, 2023

   ContributorAuthor

   More actions

   Exactly - DUs in particular are notorious; the standard encoding is sensitive to reordering of fields etc, and more, as mentioned in the linked json.net issue.

   The most common thing IME is that people use random SCDUs and typesafe enums declared in common files in serialised structs. And then, once it's in the database, you're tied to that representation forever unless you're prepared to roundtrip e.g. all the events in your event store to 'fix' them, and life is short!
3. bartelink

   changed the title [-]Feature: NewtonsoftJson: Upconvert from Case that should be a string[/-] [+]feat(NewtonsoftJson): Upconvert from Case that should be a string[/+] on Aug 8, 2023
4. bartelink commented on Apr 25, 2024

   

   bartelink

   on Apr 25, 2024

   ContributorAuthor

   More actions

   Poor man's impl:

   and ScduProxy = { Case: string; Fields: string[] }
   and private EmailAddressNsjConverter() =
       inherit FsCodec.NewtonsoftJson.JsonIsomorphism<EmailAddress, string>()
       override this.Pickle(v) = v.ToString()
       override this.UnPickle(input) = input |> EmailAddress
       override this.Read(reader, serializer) =
           if reader.TokenType = Newtonsoft.Json.JsonToken.String then base.Read(reader, serializer)
           elif reader.TokenType = Newtonsoft.Json.JsonToken.StartObject then
               // UNPACK { "Case": "EmailAddress", "Fields": [ "abc@def.com" ] }
               let p = serializer.Deserialize<ScduProxy>(reader)
               match p.Case, p.Fields with
               | "EmailAddress", [| x |] -> this.UnPickle x
               | _ -> failwith $"unexpected %A{p}"
           else failwith $"unexpected {reader.TokenType}"