Repository navigation
Remove include of common.h - #66
Closed
marcrittinghaus wants to merge 1 commit into
Closed
marcrittinghaus wants to merge 1 commit into
marcrittinghaus wants to merge 1 commit into
Conversation
When including httpserver.h the build fails because common.h is included without protecting it with HTTPSERVER_IMPL. The commit removes the include as it is not necessary. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>
Owner
|
Thanks for pointing this out. The functional tests should have caught this since the test server is built with the httpserver.h file but it seems like it was getting compiled with include paths to these headers set. Anyway I have fix these issues independently. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including
httpserver.hthe build fails with the following error becausecommon.his included without protecting it withHTTPSERVER_IMPL. The commit removes the include as it is not necessary.