Repository navigation
Include module-info.java - #81
Merged
Merged
Conversation
pietrygamat
force-pushed
the
module-info
branch
from
March 19, 2021 17:44
abfd1e3 to
0315534
Compare
pietrygamat
marked this pull request as draft
March 20, 2021 21:44
pietrygamat
force-pushed
the
module-info
branch
from
March 20, 2021 22:09
0315534 to
f50cc6d
Compare
pietrygamat
marked this pull request as ready for review
March 20, 2021 22:26
tresf
reviewed
Mar 29, 2021
tresf
reviewed
Mar 29, 2021
pietrygamat
force-pushed
the
module-info
branch
from
March 29, 2021 18:02
f50cc6d to
61024d2
Compare
tresf
reviewed
Mar 29, 2021
|
I think the only part missing before merging is issuing warning(s). How do you want to proceed? |
pietrygamat
force-pushed
the
module-info
branch
2 times, most recently
from
March 29, 2021 20:35
9928475 to
c9e3be2
Compare
pietrygamat
force-pushed
the
module-info
branch
from
March 29, 2021 20:48
c9e3be2 to
aeeedec
Compare
Collaborator
Author
OK, See the second commit to this MR. Maven warnings do get lost in the noise, but they are there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds very simple module-info to the project. For public release the artifact should be build with JDK11. This ensures that module-info is added, while the classes are still kept at bytecode version 50.0 (Java 6), so this change does not affect users in any way. Building with JDK7 or 8 will result in jar missing module-info, but otherwise functional. Building with JDK12+ is now possible, but the resulting bytecode version of jssc classes is bumped to 51 (Java 7), so it would cut backwards compatibility a bit.
#79