Skip to content

Project rename proposal #5

Closed
Closed

Description

@tresf

This is a proposal to rename the project from java-simple-serial-connector to something else. There are natural downstream effects to this:

  • Dependency name will change (e.g. Maven) affecting projects
  • Namespace changes (unavoidable -- we don't own scream3r.org and the classes aren't properly namespaced anyway)

Upsides:

  • Easier to find in a search engine
  • Shorter git clone URL

Activity

  1. bmarwell commented on Mar 27, 2019

    @bmarwell

    Dependency name does not need to change. Maven can set them independently from github URLs.
    That said, I'd still like to change the maven group:artifact to com.github.java-native:<new-project-name>.

    What we shouldn't use:

    Last project seems to be pretty advanced btw.

  2. tresf commented on Mar 29, 2019

    @tresf
    Author

    Dependency name does not need to change.

    If there's a way to offer a hint to the old project that would be nice.

    Maven can set them independently from github URLs.

    If you're suggesting we keep the old maven name with a potentially new project name, I think that'll be confusing.

    group:artifact to com.github.java-native:<new-project-name>

    Ok.

    We can just keep jssc if everyone wants, or if we want something more unique we can do a few proposals.

  3. bmarwell commented on Apr 8, 2019

    @bmarwell

    I re-read the requirements from sonar, and they suggest to use io.github as a prefix.

    Also, I'd like to propose:

      groupId=io.github.java-native.jssc
      artifactId=jssc
    

    … because we might have other artefacts in the same namespace. E.g. artifactId=jssc-parent etc.

  4. tresf commented on Apr 9, 2019

    @tresf
    Author

    jssc is probably the easiest and least confusing name. Shall I proceed?

  5. bmarwell commented on Apr 9, 2019

    @bmarwell

    Sure. While you're at it, change the project's groupId to io.github.java-native.jssc.

    Rationale: As this project might have multiple jars or poms some day, they should have a common groupId.

    That is:

      <groupId>io.github.java-native.jssc</groupId>
      <artifactId>jssc</artifactId>

    At the moment it seems duplicated, but as said, in the future we might have multiple artefacts (like jssc-parent where all the profiles and version information is, jssc-native to separate the shared objects, jssc-api to separate API and Implementation some day, etc.).

  6. tresf commented on Apr 9, 2019

    @tresf
    Author

    Sure. While you're at it, change the project's groupId to io.github.java-native.jssc.

    Done, but did I mess it up? 176f727#diff-865913557c5623f45eed23c4458032e7R21

    The maven build now says:

    [WARNING] The following patterns were never triggered in this artifact inclusion filter:
    o  'io.github.java-native:jssc'
    

    Should that be reverted?

  7. bmarwell commented on Apr 10, 2019

    @bmarwell

    Fixed with:

    Sorry for not mentioning this issue in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionSupport question, not a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions