You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dependency name does not need to change. Maven can set them independently from github URLs.
That said, I'd still like to change the maven group:artifact to com.github.java-native:<new-project-name>.
At the moment it seems duplicated, but as said, in the future we might have multiple artefacts (like jssc-parent where all the profiles and version information is, jssc-native to separate the shared objects, jssc-api to separate API and Implementation some day, etc.).
Activity
bmarwell commentedon Mar 27, 2019
Dependency name does not need to change. Maven can set them independently from github URLs.
That said, I'd still like to change the maven group:artifact to
com.github.java-native:<new-project-name>.What we shouldn't use:
see https://github.com/thibautd/JSerial
see https://www.oracle.com/technetwork/java/index-jsp-141752.html
see https://github.com/openmuc/jrxtx
Last project seems to be pretty advanced btw.
tresf commentedon Mar 29, 2019
If there's a way to offer a hint to the old project that would be nice.
If you're suggesting we keep the old maven name with a potentially new project name, I think that'll be confusing.
Ok.
We can just keep
jsscif everyone wants, or if we want something more unique we can do a few proposals.bmarwell commentedon Apr 8, 2019
I re-read the requirements from sonar, and they suggest to use
io.githubas a prefix.Also, I'd like to propose:
… because we might have other artefacts in the same namespace. E.g.
artifactId=jssc-parentetc.tresf commentedon Apr 9, 2019
jsscis probably the easiest and least confusing name. Shall I proceed?bmarwell commentedon Apr 9, 2019
Sure. While you're at it, change the project's
groupIdtoio.github.java-native.jssc.Rationale: As this project might have multiple jars or poms some day, they should have a common
groupId.That is:
At the moment it seems duplicated, but as said, in the future we might have multiple artefacts (like
jssc-parentwhere all the profiles and version information is,jssc-nativeto separate the shared objects,jssc-apito separate API and Implementation some day, etc.).tresf commentedon Apr 9, 2019
Done, but did I mess it up? 176f727#diff-865913557c5623f45eed23c4458032e7R21
The maven build now says:
Should that be reverted?
bmarwell commentedon Apr 10, 2019
Fixed with:
Sorry for not mentioning this issue in the commit message.