Skip to content

Enable javac compiler warnings #34

Closed
Closed
Enable javac compiler warnings#34
Labels
component:mavenChanges to the java build processenhancementNew feature or requestin-progresslanguage:javaNeeds changes to java sources.
Milestone
3.0.0

Description

@bmarwell
bmarwell
opened on Apr 12, 2019

Enable javac compiler warnings.

Configure the maven-compiler-plugin:

      <plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <configuration>
          <compilerArgument>-Xlint:all</compilerArgument>
          <showWarnings>true</showWarnings>
          <showDeprecation>true</showDeprecation>
        </configuration>
      </plugin>

Activity

  1. bmarwell
    added this to the Release 3.0.0 milestone on Apr 14, 2019
  2. bmarwell
    added
    component:mavenChanges to the java build process
    language:javaNeeds changes to java sources.
    on Apr 14, 2019

  3. bmarwell commented on Apr 14, 2019

    @bmarwell
    bmarwell
    on Apr 14, 2019
    Author

    Currently this will yield on jdk8:

    [WARNING] bootstrap class path not set in conjunction with -source 1.6
[WARNING] /home/user/git/jssc/src/java/jssc/SerialPortException.java:[31,8] serializable class jssc.SerialPortException has no definition of serialVersionUID
[WARNING] /home/user/git/jssc/src/java/jssc/SerialPortTimeoutException.java:[31,8] serializable class jssc.SerialPortTimeoutException has no definition of serialVersionUID
[WARNING] /home/user/git/jssc/src/java/jssc/SerialPort.java:[1017,89] found raw type: java.lang.Class
  missing type arguments for generic class java.lang.Class<T>

    On jdk11:

    [WARNING] source value 6 is obsolete and will be removed in a future release
[WARNING] target value 1.6 is obsolete and will be removed in a future release
[WARNING] To suppress warnings about obsolete options, use -Xlint:-options.

    I hate talking about "normal warnings" or even "normal errors", but we mitigate using java7+ API by using the animal sniffer plugin, so that will be fine.

    As soon as we target Java 12, we cannot build with java 8 anymore. Lowest would be java 9 then (using the -release 6 argument for javac). But that's okay for now.

  4. bmarwell
    added a commit that references this issue on Apr 14, 2019

    Add version for maven-compiler-plugin and enable linting output. Fixes …

    abb5c75

  5. tresf commented on Apr 14, 2019

    @tresf
    tresf
    on Apr 14, 2019

    Then let's avoid JDK12. JDK11 is LTS and should last us years.

  6. bmarwell
    added
    enhancementNew feature or request
    in-progress
    on Apr 14, 2019

  7. bmarwell commented on Apr 15, 2019

    @bmarwell
    bmarwell
    on Apr 15, 2019
    Author

    Yes. Exactly. Just wanted to mention it.

  8. tresf
    closed this as completedin eb0aeabon Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component:mavenChanges to the java build processenhancementNew feature or requestin-progresslanguage:javaNeeds changes to java sources.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions