Skip to content

Getters for JsonPatch* class attributes #33

Open

Description

@ssteveli

Was there a particular design reason no getters were provided in the JsonPatch classes? I'm deserializing json over the wire into instances of these classes and attempting to provide for a JSR303 validation implementation allowing me to limit patch operations, without public methods to access class attributes (i.e. path), it's seemingly impossible. I'd hate to convert to something that I can access the attributes, it seems cumbersome.

Thoughts?

Activity

  1. huggsboson commented on Aug 4, 2015

    @huggsboson
    Member

    I can't speak to @fge's rationale for it. fge hasn't really been responding here. I'm not sure if there is a new maintainer. If you made a pull request, I could find some time to setup a build on crate-metadata/json-patch and publish a build of it to maven central.

  2. chb0github commented on Jun 21, 2016

    @chb0github

    Time for a fork?

  3. huggsboson commented on Jun 21, 2016

    @huggsboson
    Member

    I got the builds setup and am happy to accept pull requests at the crate-metadata/json-patch fork and build them to maven central @ net.box.json-patch. I'm in communication with @fge about getting access to his maven central repo so that I can push builds there but haven't heard anything yet.

  4. chb0github commented on Jun 29, 2016

    @chb0github

    Can you do an actual build and release so I can depend on it?

  5. chb0github commented on Jun 29, 2016

    @chb0github

    Can you do an actual build and release so I can depend on it?

  6. huggsboson commented on Jun 29, 2016

    @huggsboson
    Member

    yeah I can do one at net.box#json-patch instead of com.github.fge#json-patch. We have to get the change merged over at the fork first though.

  7. daveclayton commented on Jul 7, 2016

    @daveclayton
    Contributor

    HI @chb0github @huggsboson , is this still required?

    Happy to consider creating a branch here for that - it sounds logical.

  8. chb0github commented on Jul 10, 2016

    @chb0github

    @daveclayton Well, anymore discussion about a a new release should be done on the forked repo as an issue and not here.

  9. jvitrifork commented on Jun 17, 2019

    @jvitrifork
    Contributor

    did anything happen to this feature request?

  10. chb0github commented on Jun 17, 2019

    @chb0github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions