Property Color unset invalid value #19

Activity

1. jaraco commented on Feb 23, 2022

   

   jaraco

   on Feb 23, 2022

   Owner

   More actions

   Looks like unset is a legitimate setting. I welcome a patch to fix it.
2. jaraco

   added

   help wantedExtra attention is neededExtra attention is needed

   on Feb 23, 2022
3. Madin-H23 commented on Oct 21, 2026

   

   Madin-H23

   on Oct 21, 2026

   More actions

   Hi @Thokas — thanks for the report. You are right: on current main cssutils.profile.validate('color', 'unset') is False, while inherit is accepted:

   >>> cssutils.profile.validate('color', 'inherit')
   True
   >>> cssutils.profile.validate('color', 'unset')
   False

   The values are validated against the profile regexes, and the CSS-wide keywords only appear in the regexes where they were spelled out per property.

   Per CSS Values 4 the CSS-wide keywords (initial, inherit, unset, revert) are valid in place of the value of any property, so I would like to accept them for every property rather than only for color.

   My plan:

   • accept the CSS-wide keywords for every property (they are added where the property regexes are compiled, so the per-property definitions stay untouched),
   • keep invalid values invalid — only those four keywords are added,
   • update the one existing expectation that relied on an @font-face descriptor rejecting inherit,
   • add tests and a news fragment.

   I will open a PR with the change.