Skip to content

FOX-122: Keep unpaired traffic from blocking paired devices - #87

Open
jamarks wants to merge 2 commits into
mainfrom
agent/fox-122-keep-unpaired-traffic-from-blocking-pair
Open

jamarks wants to merge 2 commits into
mainfrom
agent/fox-122-keep-unpaired-traffic-from-blocking-pair

Conversation

@jamarks

@jamarks jamarks commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Why: share.mjs:20,70-88 uses one global 120-requests-per-minute counter, incremented before checking the fox_device grant. Anyone who knows the active Quick Tunnel hostname can send unauthenticated requests to exhaust it and keep paired users from HTTP panel access or completing pairing. Confirmed by executing the share.mjs handler with a stub tunnel and real pairing logic: a paired cookie received 200 for /api/overview, then 120 unpaired GET / requests made the same paired cookie receive 429 (exit 0).

Separated bounded anonymous and paired gateway quotas so unpaired traffic cannot consume the paired quota.

Try it: No UI change; the behavior is covered in tests/share.test.mjs.

Verified: node --test tests/share.test.mjs, npm test (253 passed), and git diff --check all passed with exit code 0.

Change: 2 files, 30 lines. Tests pass (npm test), run by the job.

Linear: https://linear.app/fox-cli/issue/FOX-122/keep-unpaired-traffic-from-blocking-paired-devices

Merging publishes it to release on the job's next run.

Made by a fox job (20261105-100000-660ea9).

Separated bounded anonymous and paired gateway quotas so unpaired traffic cannot consume the paired quota.

Linear: https://linear.app/fox-cli/issue/FOX-122/keep-unpaired-traffic-from-blocking-paired-devices
…d-device quota; I strengthened its coverage.
@jamarks

jamarks commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

🔧 fox review (gpt-6-sol): The PR keeps anonymous HTTP traffic from exhausting the paired-device quota; I strengthened its coverage.

  • Fixed missing coverage: forged device cookies remain in the anonymous quota, and valid devices eventually reach the paired quota.

Fixes pushed to this branch in 0a221fd; tests pass (npm test), run by the job.

fox-review: 0a221fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant