Repository navigation
Conversation
Separated bounded anonymous and paired gateway quotas so unpaired traffic cannot consume the paired quota. Linear: https://linear.app/fox-cli/issue/FOX-122/keep-unpaired-traffic-from-blocking-paired-devices
…d-device quota; I strengthened its coverage.
Owner
Author
|
🔧 fox review (gpt-6-sol): The PR keeps anonymous HTTP traffic from exhausting the paired-device quota; I strengthened its coverage.
Fixes pushed to this branch in 0a221fd; tests pass ( fox-review: 0a221fd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: share.mjs:20,70-88 uses one global 120-requests-per-minute counter, incremented before checking the fox_device grant. Anyone who knows the active Quick Tunnel hostname can send unauthenticated requests to exhaust it and keep paired users from HTTP panel access or completing pairing. Confirmed by executing the share.mjs handler with a stub tunnel and real pairing logic: a paired cookie received 200 for /api/overview, then 120 unpaired GET / requests made the same paired cookie receive 429 (exit 0).
Separated bounded anonymous and paired gateway quotas so unpaired traffic cannot consume the paired quota.
Try it: No UI change; the behavior is covered in tests/share.test.mjs.
Verified: node --test tests/share.test.mjs, npm test (253 passed), and git diff --check all passed with exit code 0.
Change: 2 files, 30 lines. Tests pass (
npm test), run by the job.Linear: https://linear.app/fox-cli/issue/FOX-122/keep-unpaired-traffic-from-blocking-paired-devices
Merging publishes it to
releaseon the job's next run.Made by a fox job (20261105-100000-660ea9).