Repository navigation
FOX-120: Apply a byte limit to binary changes proposed by agents - #85
Merged
jamarks merged 2 commits intoNov 5, 2026
Merged
Conversation
Added a 256 KiB limit on total staged binary blob bytes before a job can commit or push, with rejection and small-binary tests. Linear: https://linear.app/fox-cli/issue/FOX-120/apply-a-byte-limit-to-binary-changes-proposed-by-agents
…sts and clarified the documentation.
Owner
Author
|
🔧 fox review (gpt-6-sol): The binary byte limit works as intended; I added edge-case tests and clarified the documentation.
Fixes pushed to this branch in f584cf1; tests pass ( fox-review: f584cf1 |
jamarks
added a commit
that referenced
this pull request
Nov 5, 2026
jamarks
added a commit
that referenced
this pull request
Nov 6, 2026
jamarks
added a commit
that referenced
this pull request
Nov 7, 2026
jamarks
added a commit
that referenced
this pull request
Nov 8, 2026
jamarks
added a commit
that referenced
this pull request
Nov 9, 2026
jamarks
added a commit
that referenced
this pull request
Nov 10, 2026
jamarks
added a commit
that referenced
this pull request
Nov 11, 2026
jamarks
added a commit
that referenced
this pull request
Nov 12, 2026
jamarks
added a commit
that referenced
this pull request
Nov 13, 2026
jamarks
added a commit
that referenced
this pull request
Nov 14, 2026
jamarks
added a commit
that referenced
this pull request
Nov 15, 2026
jamarks
added a commit
that referenced
this pull request
Nov 16, 2026
jamarks
added a commit
that referenced
this pull request
Nov 17, 2026
jamarks
added a commit
that referenced
this pull request
Nov 18, 2026
jamarks
added a commit
that referenced
this pull request
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: lib/python/foxjob.py:160-163 counts binary entries in git diff --numstat as zero lines; lines 223-246 then approve the proposal on that count and would push it when not dry. A model controlling the changed files can add an arbitrarily large binary artifact while bypassing max_lines, including data copied from files it could access, and the helper's stated size check will not stop publication. In an isolated fake-fx/local-git test I added a 1,000,000-byte payload.bin and called propose_change(max_lines=0, dry=True): it returned dry-run with files=1, lines=0 and reported it would push/open a PR.
Added a 256 KiB limit on total staged binary blob bytes before a job can commit or push, with rejection and small-binary tests.
Try it: Use foxjob.propose_change(); set max_binary_bytes to adjust the default limit.
Verified: python3 -m unittest discover -s lib/python/tests -q passed (12 tests, exit 0); npm test passed (249 tests, exit 0); git diff --check passed (exit 0).
Change: 3 files, 42 lines. Tests pass (
npm test), run by the job.Linear: https://linear.app/fox-cli/issue/FOX-120/apply-a-byte-limit-to-binary-changes-proposed-by-agents
Merging publishes it to
releaseon the job's next run.Made by a fox job (20261104-180004-829c9a).