Repository navigation
Expose new fx settings as opt-in controls - #76
Merged
Merged
Conversation
Added an opt-in terminal theme control to existing Settings → fx, with theme verified against installed fx using temporary-HOME wrong-type and valid-value probes.
jamarks
added a commit
that referenced
this pull request
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an opt-in terminal theme control to existing Settings → fx, with theme verified against installed fx using temporary-HOME wrong-type and valid-value probes.
Try it: Open Settings → fx → Terminal theme, enter light or dark, then enable Apply setting. Built option A for compactness; screenshots include both alternatives.
Verified: npm test: 247 passed, exit 0; git diff --check: exit 0. Theme number produced malformed_settings; light/dark were quiet. Browser validation, activation/removal, badge persistence and mobile layout passed; screenshots saved. Existing auth-disabled 404 was isolated with a browser mock; no subsequent console errors. No real settings changed.
Change: 4 files, 129 lines. Tests pass (
npm test), run by the job.Sources:
New controls are opt-in and marked New. No automatic merge or deployment.
Made by a fox job (20261101-080010-38eece).