Skip to content

FOX-45: Live checks on what fx changed: lint and type errors next to its files - #72

Merged
jamarks merged 3 commits into
mainfrom
agent/fox-45-live-checks-on-what-fx-changed-lint-and-
Oct 31, 2026
Merged

jamarks merged 3 commits into
mainfrom
agent/fox-45-live-checks-on-what-fx-changed-lint-and-

Conversation

@jamarks

@jamarks jamarks commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Why: fx writes files and fox lists them, but you only learn they break lint or types when fx runs the tests, if it does. Pi's pi-lens package (live LSP, linter and type feedback) is popular because it catches this as it happens.

Added opt-in post-turn checks with bounded commands and file-level diagnostics; chose option A because errors appear beside the affected file.

Try it: In workspace settings, enable “Check fx's changes.” After an fx turn, inspect the files column and session header; screenshots show the settings and three UI alternatives.

Verified: npm test passed (exit 0, 229/229); focused tests and syntax checks passed. Inspected the UI in a read-only browser preview; diagnostic screenshots use sample output, so a live repo check was not exercised.

Change: 10 files, 290 lines. Tests pass (npm test), run by the job.

Linear: https://linear.app/fox-cli/issue/FOX-45/live-checks-on-what-fx-changed-lint-and-type-errors-next-to-its-files

Merging publishes it to release on the job's next run.

Made by a fox job (20261030-120012-620b4c).

…its files

Added opt-in post-turn checks with bounded commands and file-level diagnostics; chose option A because errors appear beside the affected file.

Linear: https://linear.app/fox-cli/issue/FOX-45/live-checks-on-what-fx-changed-lint-and-type-errors-next-to-its-files
…ed, but a live diagnostic remains unverified against real sessions.
@jamarks

jamarks commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

🔧 fox review (gpt-6-sol): Fixed correctness gaps in the opt-in checks; the PR is improved, but a live diagnostic remains unverified against real sessions.

  • Fixed: run both lint and typecheck when declared, without assuming lint accepts file arguments.
  • Fixed: use subagent write events rather than later file mtimes; show ESLint diagnostics beside the file.
  • Fixed: validate saved commands and avoid running checks on turns completed before checks were enabled.
  • Not fixed: the attached diagnostic screenshots are mockups, not proof with real session results; their repeated deleted-file rows add noise and do not demonstrate the feature.

Fixes pushed to this branch in b77e9a3; tests pass (npm test), run by the job.

fox-review: b77e9a3

…ript meta

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jamarks
jamarks merged commit 8ec538c into main Oct 31, 2026
jamarks added a commit that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant