Skip to content

Support source installation with an existing Isaac Lab runtime - #24

Open
nblauch wants to merge 3 commits into
isaac-sim:mainfrom
nblauch:fix/source-isaaclab-dependency
Open

nblauch wants to merge 3 commits into
isaac-sim:mainfrom
nblauch:fix/source-isaaclab-dependency

Conversation

@nblauch

@nblauch nblauch commented Oct 20, 2026 •

Copy link
Copy Markdown

Git source installation should work alongside an existing Isaac Lab runtime. Two packaging issues currently prevent that:

  • The tutorial requires exactly isaaclab==3.0.0, so its metadata cannot resolve with an editable source distribution reporting version 37.2.0. Allow isaaclab>=3.0.0; the existing monolithic release still satisfies the requirement.
  • Git-built packages can contain LFS pointer text for the required desk, rack and vial USD layers. Store those six runtime layers (including referenced geometry) as ordinary Git blobs, as already done for the reset dataset. Their asset contents are unchanged; each SHA-256 matches its original LFS object ID. Optional media and unused larger layers remain in LFS.

Validation:

  • The original metadata fails a resolver dry-run with the selected isaaclab==37.2.0; the revised requirement resolves.
  • A Git-installed package before the asset fix failed native scene loading because vial.usda was LFS pointer text.
  • All six installed runtime layers are byte-identical to their original assets and compose successfully. A native numbered-vial CNN smoke run completed four PPO iterations with actor parameter updates.
  • The tutorial's normal uv lock completed without lockfile changes.
  • Pre-commit checks passed on changed files. A repository-wide run also found an existing blank-line formatting issue in the unchanged reset generator; that unrelated edit was reverted.

This changes dependency and source-package storage metadata, without changing the task's physics or asset contents.

@nblauch nblauch changed the title Allow the tutorial to use Isaac Lab source packages Support source installation with an existing Isaac Lab runtime Oct 20, 2026
@nblauch
nblauch marked this pull request as ready for review October 20, 2026 23:47
@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR lets Git source installs use an existing Isaac Lab runtime and load the workshop assets without Git LFS.

  • Git-built tutorial packages include the workshop scene layers.
  • The tutorial accepts Isaac Lab versions from 3.0.0 onward.

Review checks covered asset checksums, local references, package settings, and the locked dependency. Simulator tests were not run.

Reviews (1) · Last reviewed commit: "Include referenced workshop geometry lay..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant