Repository navigation
Conversation
nblauch
marked this pull request as ready for review
October 20, 2026 23:47
[Medium impact] This PR appears safe to merge; no actionable issues were found. SummaryThis PR lets Git source installs use an existing Isaac Lab runtime and load the workshop assets without Git LFS.
Review checks covered asset checksums, local references, package settings, and the locked dependency. Simulator tests were not run. Reviews (1) · Last reviewed commit: "Include referenced workshop geometry lay..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git source installation should work alongside an existing Isaac Lab runtime. Two packaging issues currently prevent that:
isaaclab==3.0.0, so its metadata cannot resolve with an editable source distribution reporting version 37.2.0. Allowisaaclab>=3.0.0; the existing monolithic release still satisfies the requirement.Validation:
isaaclab==37.2.0; the revised requirement resolves.vial.usdawas LFS pointer text.uv lockcompleted without lockfile changes.This changes dependency and source-package storage metadata, without changing the task's physics or asset contents.