Compatibility with pytest 8

According to: https://docs.pytest.org/en/latest/deprecations.html#id14 pytest 8 no longer supports setup/teardown functions/methods which leads to many failures like this:

____________________________ test_asyncio_interrupt ____________________________

    @pytest.mark.skipif(tornado.version_info < (5,), reason="only relevant on tornado 5")
    def test_asyncio_interrupt():
>       assert KM is not None
E       assert None is not None

ipykernel/tests/test_eventloop.py:67: AssertionError

Because these functions are ignored:

ipykernel/tests/test_eventloop.py

Lines 45 to 56 in 5534fd9

    
           def setup(): 
        
               """start the global kernel (if it isn't running) and return its client""" 
        
               global KM, KC 
        
               KM, KC = start_new_kernel() 
        
               flush_channels(KC) 
        
           def teardown(): 
        
               assert KM is not None 
        
               assert KC is not None 
        
               KC.stop_channels() 
        
               KM.shutdown_kernel(now=True)

Thanks! I opened #1231.

Navigation Menu

Repository navigation

Compatibility with pytest 8 #1230

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def setup():
	"""start the global kernel (if it isn't running) and return its client"""
	global KM, KC
	KM, KC = start_new_kernel()
	flush_channels(KC)


	def teardown():
	assert KM is not None
	assert KC is not None
	KC.stop_channels()
	KM.shutdown_kernel(now=True)

Compatibility with pytest 8 #1230

Description

Activity

blink1073 commented on Apr 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions