Repository navigation
Patching ipmitool to response more quickly if sp is not communicable. #98
Description
Reported by: Elaine Li
Original Ticket: ipmitool/bugs/507
If sp is not communicable, use this patch can reduce response time.
Test in our environment use -C 3 -R 4 -N 3
- original: 49s
- patch: 36s
diff -ruN ipmitool-1.8.18.orig/src/ipmishell.c ipmitool-1.8.18.new/src/ipmishell.c
--- ipmitool-1.8.18.orig/src/ipmishell.c 2016-03-13 17:57:04.000000000 +0800
+++ ipmitool-1.8.18.new/src/ipmishell.c 2018-03-01 11:18:35.923428181 +0800
@@ -233,6 +233,7 @@
printf("%s ", argv[i]);
}
printf("\n");
-
fflush(stdout);
return 0;
}
Activity
AlexanderAmelkin commentedon Mar 30, 2018
This patch only speeds up the
echocommand output. It doesn't speed up anything else. I don't see how this may help in situations when sp (service processor?) is "not communicable".Besides, next time please attach patches rather than copy-paste them. Or better yet, create pull requests.
Original comment by: Alexander Amelkin
AlexanderAmelkin commentedon Apr 9, 2018
Yes, to speed up output is not affect on service processor itself. Due to we use ipmitool to do service process discovery, collect info and add to our manage list if target is communicable.
In our test example, one target reduce 13s, 100 targets will reduce 21 min waitting time. To reduce waitting time for not communicable target is really help performance improvement.
Original comment by: Elaine Li