Skip to content
This repository was archived by the owner on Apr 2, 2018. It is now read-only.
This repository was archived by the owner on Apr 2, 2018. It is now read-only.

Cordova-custom-config plugin fails on ionic:package build (ionic.io) #26

Open

Description

@BramDecuypere

Our build server has been working for a while and pushing to ionic.io.
Suddenly it stopped working after adding this plugin:
cordova-custom-config
We currently removed this plugin and now it's working again.

The errors we get from ionic.io:

  • Android: Error opening android-debug.apk
  • iOS: error: Specified application doesn't exist or isn't a bundle directory : '/Users/package/workspace/apps-f2b1ce46-628/cordova/platforms/ios/build/device/MyApp.app'

Locally this build works, we get it running on a device, so our guess is that
the problem isn't something we can solve.

Any ideas are welcome!
Some relevant code on how we use this plugin:

config.xml:

...
<platform name="android">
    <config-file parent="/*" target="AndroidManifest.xml">
        <uses-permission android:name="android.permission.CAMERA" />
        <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
    </config-file>
</platform>
...

package.json:

...
"cordovaPlugins": [
   ...
    "cordova-custom-config"
  ],
...

Your system information:
Cordova CLI: Not installed
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.34
OS: Distributor ID: Ubuntu Description: Ubuntu 16.04.1 LTS
Node Version: v6.8.1

Activity

  1. luckylooke commented on Apr 25, 2017

    @luckylooke

    This is not going to work, because ionic cloud doesnt support hooks, which cordova-custom-config is depend on. dpa99c/cordova-custom-config#112 (comment)

  2. janpio commented on May 17, 2017

    @janpio

    Also this plugin/hook should probably not be required any more as Cordova supports setting config file values in config.xml itself now: https://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#edit-config (Docs say plugin.xml right now, but it also works in config.xml) Much simpler and cleaner.

  3. luckylooke commented on May 19, 2017

    @luckylooke

    @piotrowski nice! But unfortunatelly I need to change iOS platform xxx-Info.plist where values are structured like this:

     <dict>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleDisplayName</key>
        <string>${PRODUCT_NAME}</string>
        <key>CFBundleExecutable</key>
        <string>${EXECUTABLE_NAME}</string>
        <key>CFBundleIcons</key>
    ...
     </dict>

    And edit-config needs target as XPath, but there is no way in XPath I can select CFBundleDevelopmentRegion and change sibling element :/

    The only option for .plist is to replace whole with edit-config mode="overwrite", but I don't know if it is good idea, if it does not break something else..

    But for AndroidManifest it is very good option! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions