Skip to content

AuthClient shouldn't subclass Session. #16

Open
Open
AuthClient shouldn't subclass Session.#16

Description

@dreid
dreid
opened on Oct 29, 2019

It doesn't need to be a Session to have a Session. Subclassing Session drastically increases it's API surface for no benefit.

Activity

  1. fjolin-intuit commented on Nov 15, 2019

    @fjolin-intuit
    fjolin-intuit
    on Nov 15, 2019
    Contributor

    Hi @dreid. Thanks for posting the issue - We are having a look currently and will consider removing the subclass.

  2. fjolin-intuit
    added
    hacktoberfest
    on Sep 10, 2020

  3. fjolin-intuit commented on Sep 10, 2020

    @fjolin-intuit
    fjolin-intuit
    on Sep 10, 2020
    Contributor

    @dreid We are opening up our clients for contribution for hacktoberfest.

  4. fjolin-intuit
    removed
    hacktoberfest
    on Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions