Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Dead code removal #86

Merged
dawagner merged 3 commits into from
Apr 13, 2015
Merged

Dead code removal #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31067e7
Remove unused CElement::getLastChild method
Apr 10, 2015
466e0ea
Remove unsued CElement::findAscendantOfKind method
Apr 10, 2015
8b18043
Remove unused CXmlElement::setComment method
Apr 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions parameter/Element.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,15 +401,6 @@ const CElement* CElement::getChild(size_t uiIndex) const
return _childArray[uiIndex];
}

CElement* CElement::getLastChild()
{
size_t uiNbChildren = getNbChildren();

assert(uiNbChildren);

return _childArray[uiNbChildren - 1];
}

CElement* CElement::createChild(const CXmlElement& childElement,
CXmlSerializingContext& serializingContext)
{
Expand Down Expand Up @@ -600,20 +591,6 @@ bool CElement::isDescendantOf(const CElement* pCandidateAscendant) const
return _pParent->isDescendantOf(pCandidateAscendant);
}

CElement* CElement::findAscendantOfKind(const string& strKind)
{
if (!_pParent) {

return NULL;
}

if (_pParent->getKind() == strKind) {

return _pParent;
}
return _pParent->findAscendantOfKind(strKind);
}

CElement* CElement::findChild(const string& strName)
{
uint32_t uiIndex;
Expand Down
2 changes: 0 additions & 2 deletions parameter/Element.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ class CElement : public IXmlSink, public IXmlSource
static void appendTitle(std::string& strTo, const std::string& strTitle);

// Hierarchy
CElement* getLastChild();
CElement* getParent();
CElement* findAscendantOfKind(const std::string& strKind);

/**
* Creates a child CElement from a child XML Element
Expand Down
5 changes: 0 additions & 5 deletions xmlserializer/XmlElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,6 @@ void CXmlElement::setTextContent(const string& strContent)
xmlAddChild(_pXmlElement, xmlNewText(BAD_CAST strContent.c_str()));
}

void CXmlElement::setComment(const string& strComment)
{
xmlAddChild(_pXmlElement, xmlNewComment(BAD_CAST strComment.c_str()));
}

// Child creation
void CXmlElement::createChild(CXmlElement& childElement, const string& strType)
{
Expand Down
1 change: 0 additions & 1 deletion xmlserializer/XmlElement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ class CXmlElement
void setAttributeString(const std::string& strAttributeName, const std::string& strValue);
void setNameAttribute(const std::string& strValue);
void setTextContent(const std::string& strContent);
void setComment(const std::string& strComment);
void setAttributeInteger(const std::string& strAttributeName, uint32_t uiValue);
/**
* Set attribute with signed integer
Expand Down