Repository navigation
feat: Add support for multihost configuration - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the PSM host-selection changes, which retain host 0 as the default.
No open issues 🎉
What changed in this PR
Adds host selection to PSM configuration methods so callers can target hosts beyond host 0, while preserving host 0 as the default.
Changes:
- Adds and forwards
host_idfor VM creation, VF-to-VM mapping, and VM rate limits. - Includes host information in logs and errors, and updates API documentation.
- Extends unit tests to verify non-default host selection and default-host forwarding.
| File | Description |
|---|---|
tests/unit/test_mfd_cli_client/test_base.py |
Verifies host forwarding and generated commands for non-default hosts. |
README.md |
Documents host parameters and corrects the rate-limit method description. |
mfd_cli_client/base.py |
Adds host selection to PSM methods, commands, logs, and errors. |
Review effort: Balanced
adrianlasota
approved these changes
Nov 4, 2026
mchromin
approved these changes
Nov 4, 2026
PSM commands were all running on host 0 by default. Add support so we can run the commands on xhc1, xhc2 etc. Signed-off-by: Dhiraj Lulla <dhiraj.lulla@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSM commands were all running on host 0 by default. Add support so we can run the commands on xhc1, xhc2 etc.