Repository navigation
Conversation
The stack pins grafana/grafana:9.3.0 (December 2022). That release has been end-of-life for years: every CVE fixed since - including the auth-bypass and XSS fixes in 9.5/10.x - is missing from the monitoring stack every node operator runs. Bump the default to 12.4.14 (the current 12.x line, still receiving patches; 13.2.5 is available if you would rather jump to the newest major). Compatibility was checked against the shipped dashboard before bumping: - schemaVersion 37 is auto-migrated by Grafana on load - panel types are gauge/row/stat/timeseries - all core panels, no removed 'graph' panel - the dashboard's datasource uid 6R74VAnVz matches the provisioned datasource uid - provisioning apiVersion 1, GF_SECURITY_ADMIN_PASSWORD and the file-based dashboard provider are unchanged in 12.x While in there, fix the provisioning schema: both files use org_id, which modern Grafana ignores (it expects orgId), so the datasource and dashboard provider silently fall back to org 1. Use the documented key. Also drop the two InfluxDB entries from deleteDatasources - InfluxDB left the stack in inkonchain#97, so they can never match anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the Go toolchain and Foundry from
docker/dockerfiles/Dockerfile.bedrock-init:and updates the README sentence that claimed the container installs Foundry.
Why
Nothing in the image uses either toolchain:
scripts/init-bedrock.shcurl,tar,sha256sum,openssl,mkdir,dirnamescripts/utils.sharia2c(aria2),unzstd(zstd),lz4, coreutilsgrepacrossscripts/,docker/and the repo history finds nocast,forge,anvilorgoinvocation — they were never referenced by any container-side script. They look cargo-culted from the upstreamsimple-optimism-nodetemplate this repo was forked from.Effect: every
docker compose up --buildbuilds a smaller image (~1.2 GB less to pull/extract on first boot, which matters because the first boot is already dominated by a 250-400 GB snapshot download), and the build loses acurl | bashstep that fetched a third-party installer.progress.shstill needscast, but it runs on the host — that is unchanged and the README now says so directly.Verification
git grep -nE '\b(cast|forge|anvil)\b'over tracked files → onlyprogress.sh, which is host-side)docker-compose.ymluntouched; the image still installs everythinginit-bedrock.sh/utils.shcallNot verified: an actual
docker build(no Docker in this environment) — the change only deletes twoRUNblocks that nothing depends on.