Repository navigation
fix: don't borrow FIELDS in generated expecting() formatting - #161
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the changes removing redundant borrows from generated Serde expecting() messages.
No open issues 🎉
What changed in this PR
Removes redundant borrows from generated Serde expecting() messages to address Clippy’s useless_borrows_in_formatting warnings without changing formatted output.
Changes:
- Passes
FIELDSdirectly towrite!in both message and enum generators.
| File | Description |
|---|---|
pbjson-build/src/generator/message.rs |
Removes the extra borrow in generated field-name visitor formatting. |
pbjson-build/src/generator/enumeration.rs |
Removes the extra borrow in generated enum visitor formatting. |
Review effort: Balanced
Contributor
Author
|
All CircleCI jobs fail at the |
itsjunetime
approved these changes
Nov 9, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated
expecting()impls pass&FIELDStowrite!.FIELDSis already&[&str], and Rust 1.99 clippy flags the extra borrow withuseless_borrows_in_formattingin every crate that includes the generated code. Downstream crates currently silence it (e.g. influxdb_iox#16869).This drops the
&in the message and enum generators. With clippy 1.99,pbjson-testgoes from 2 warnings for this lint to 0.