Repository navigation
Fix crashing Hankel1.n() calls - #306
Merged
Merged
Conversation
alexfikl
force-pushed
the
symengine-hankel-evalf
branch
from
September 12, 2026 16:30
8fa3f89 to
70e88b3
Compare
This was referenced Sep 12, 2026
inducer
force-pushed
the
symengine-hankel-evalf
branch
from
September 12, 2026 19:19
70e88b3 to
ffa511b
Compare
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, the test was hard segfaulting on
mainbecause it was getting somewhere intosymenginethat assumes function wrappers of this type always return numeric values on.n(). It was then trying to cast that to a number and crashing..The fix here works if the arguments to
Hankel1/BesselJare actually numeric, by going throughsympyto evaluate them. If they're not numeric it still crashes, so that needs some code insymengineandsymengine.py.