Repository navigation
Deprecate empty / empty_like / zeros_like - #184
Merged
Merged
Conversation
alexfikl
force-pushed
the
deprecate-actx-empty
branch
from
July 2, 2022 08:24
49c0f7e to
b2785c4
Compare
alexfikl
commented
Jul 2, 2022
alexfikl
force-pushed
the
deprecate-actx-empty
branch
from
July 3, 2022 07:17
b2785c4 to
7283002
Compare
alexfikl
force-pushed
the
deprecate-actx-empty
branch
from
August 13, 2022 06:23
7283002 to
e1df9a8
Compare
alexfikl
force-pushed
the
deprecate-actx-empty
branch
from
September 30, 2022 07:27
e1df9a8 to
90aaf50
Compare
alexfikl
force-pushed
the
deprecate-actx-empty
branch
from
September 30, 2022 07:31
90aaf50 to
19e3b3b
Compare
Owner
In either case, each of you, please let me know yea or nay so this can get merged. |
kaushikcfd
approved these changes
Oct 1, 2022
kaushikcfd
left a comment
kaushikcfd
left a comment
Collaborator
There was a problem hiding this comment.
One small query, otherwise this LGTM!
I do like that clearly specifying that using a lot of if actx.suport_xxx to branch is a non-pattern. Thanks!
inducer
force-pushed
the
deprecate-actx-empty
branch
from
October 1, 2022 19:06
69a3d94 to
cb38ca2
Compare
alexfikl
commented
Oct 2, 2022
alexfikl
left a comment
alexfikl
left a comment
Collaborator
Author
There was a problem hiding this comment.
Added a little (non-blocking) question, but overall that looks sensible and we've been following most of it already!
Owner
|
Thanks to both of you for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #178, this
emptyandempty_like.actx.np.empty_likefor the contexts that supported that.actx.zeros_likein favor ofactx.np.zeros_like.