Skip to content

We don't search for another sym for accessors to prevent us from  #779

Open
Open
We don't search for another sym for accessors to prevent us from #779
Labels
REVIEW

Description

@piascikj
piascikj
opened on Jan 6, 2018

accidentally coalescing function signatures with the same name (E.g., a function
'f' the outer scope and a setter 'f' in an object literal within that scope)

opened via imdone.io from a code comment on 966fa16

REVIEW We don't search for another sym for accessors to prevent us from id:778

TypeScript/tests/cases/conformance/parser/ecmascript5/parserRealSource8.ts

Lines 266 to 273 in 966fa16

// REVIEW: We don't search for another sym for accessors to prevent us from
// accidentally coalescing function signatures with the same name (E.g., a function
// 'f' the outer scope and a setter 'f' in an object literal within that scope)
if (nameText && nameText != "__missing" && !funcDecl.isAccessor()) {
if (isStatic) {
fgSym = funcScope.findLocal(nameText, false, false);
}
else {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    REVIEW

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions