Repository navigation
Updates to automatic sender for IR1 - #78
Merged
Merged
Conversation
physics-png
reviewed
Oct 29, 2026
physics-png
left a comment
physics-png
left a comment
Collaborator
There was a problem hiding this comment.
looks good overall, some minor comments and suggestions
physics-png
approved these changes
Oct 29, 2026
physics-png
left a comment
physics-png
left a comment
Collaborator
There was a problem hiding this comment.
looks great thnx for addressing comments quickly
Collaborator
Author
|
GCN PRs are approved and likely will be merged soon. @physics-png I am going to wait til they're merged, then remove the placeholders and put the actual version once they do the release, rather than doing a fresh PR for this |
Collaborator
Author
|
@physics-png GCN has the new schema release, so I've added that. This should be ready to merge now, whenever you approve! |
physics-png
approved these changes
Nov 9, 2026
physics-png
left a comment
physics-png
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good! Sorry for not getting to this sooner
physics-png
approved these changes
Nov 9, 2026
physics-png
left a comment
physics-png
left a comment
Collaborator
There was a problem hiding this comment.
We both were pranked, looks good (x2)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to update the sender script (
combine_results_kafka) to use the GCN-Kafka LVK GCNs. It also updates the format of thelvk_nu_track_searchstream to match the associated updates to our schema. It is ready for review, but will continue to have updates as preparations for the run continue.Changes
python-dotenvfor handling env variablesrun_2week_gw_followup.pyscript__init__.pyfor slack poster utilities so that docs can make properly