Skip to content

Refactored tag handling methods to support numerical ids - #65

Merged
adamwojs merged 1 commit into
mainfrom
numerical_ids
May 1, 2025
Merged

Refactored tag handling methods to support numerical ids#65
adamwojs merged 1 commit into
mainfrom
numerical_ids

Conversation

@adamwojs

@adamwojs adamwojs commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
🎫 Issue IBX-XXXXX

Description:

Follow up for #63.

Issue detected by https://github.com/ibexa/fieldtype-page/actions/runs/14773790369/job/41478333517

    │  	[2025-05-01T10:26:13.389330+00:00] request.CRITICAL: Uncaught PHP Exception TypeError: "Ibexa\HttpCache\Handler\TagHandler::Ibexa\HttpCache\Handler\{closure}(): Argument #1 ($locationId) must be of type string, null given" at TagHandler.php line 137 {"exception":"[object] (TypeError(code: 0): Ibexa\\HttpCache\\Handler\\TagHandler::Ibexa\\HttpCache\\Handler\\{closure}(): Argument #1 ($locationId) must be of type string, null given at /var/www/vendor/ibexa/http-cache/src/lib/Handler/TagHandler.php:137)"} []

For QA:

N/A

Documentation:

N/A

@sonarqubecloud

sonarqubecloud Bot commented May 1, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adamwojs
adamwojs commented May 1, 2025
View reviewed changes
Comment thread src/lib/Handler/TagHandler.php
public function addLocationTags(array $locationIds): void
{
$this->addTags(array_map(static function (string $locationId): string {
$tags = array_map(static function (string|int|null $locationId): string {

@adamwojs adamwojs May 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location generated for content preview have id = null.

@adamwojs
adamwojs merged commit 3dfa4ef into main May 1, 2025
@adamwojs
adamwojs deleted the numerical_ids branch May 1, 2025 13:49
@adamwojs

adamwojs commented May 1, 2025

Copy link
Copy Markdown
Member Author

Fixed build: https://github.com/ibexa/fieldtype-page/actions/runs/14773790369/job/41486311507

vidarl added a commit that referenced this pull request Aug 18, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
5267f47
vidarl added a commit that referenced this pull request Aug 18, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
434e83e
vidarl added a commit that referenced this pull request Aug 19, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
15d27f9
vidarl added a commit that referenced this pull request Oct 8, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
1cf910d
vidarl added a commit that referenced this pull request Oct 8, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
131cf41
vidarl added a commit that referenced this pull request Oct 12, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
f751d65
vidarl added a commit that referenced this pull request Oct 12, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
19690e1
vidarl added a commit that referenced this pull request Oct 12, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
fc5e116
vidarl added a commit that referenced this pull request Oct 14, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
9d4791b
vidarl added a commit that referenced this pull request Oct 14, 2026
@vidarl
[TMP] Added dependencies.json linking ibexa/docker PR #65
03221b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alongosz alongosz

@konradoboza konradoboza

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamwojs @alongosz @konradoboza