Repository navigation
Conversation
…" setting with an opt-in "ibexa.installer.doctrine_migrations"
Steveb-p
marked this pull request as ready for review
October 16, 2026 11:22
Steveb-p
added
Ready for review
Doc needed
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
October 16, 2026 11:35
bnowak
approved these changes
Oct 16, 2026
…ling back in the extension Covered the nested "enabled" syntax of "ibexa.installer.doctrine_migrations" in the extension test as well.
…er config test case
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
ibexa.installer.schema_builder_event.enabled: falseturned out to be hard to explain: you turn the new Doctrine Migrations install path on by turning the legacy one off. This replaces it with a positive opt-in:ibexa.installer.doctrine_migrationsis a bundle configuration node built withcanBeEnabled(), sodoctrine_migrations: { enabled: true }works too. It defaults tofalse, which keepsibexa:installonSchemaBuilderEvent, same as before. Once the default flips in a later major, the node becomescanBeDisabled().IbexaCoreExtensionhands the resolved value toCoreInstallerthrough theibexa.installer.doctrine_migrations.enabledcontainer parameter.CoreInstaller's$schemaBuilderEventEnabledargument became$doctrineMigrationsEnabled, with bothimportSchema()andimportData()inverted to match.There's no BC layer for the old key on purpose: it came in with #785 and no release contains it yet. Configuring it now fails with
Unrecognized option "schema_builder_event" under "ibexa.installer".ibexa/installer's product installers getCoreInstaller's arguments throughparent:as named ones, so ibexa/installer#239 renames the argument there as well. With only one of the two in, the container doesn't build (method "__construct()" has no argument named "$doctrineMigrationsEnabled"), same as with #785 and ibexa/installer#213.The two new
IbexaCoreExtensionTestcases bring the unit suite to 239 direct deprecations out of the allowed 240: every extension load triggers 2 of them, from the old-stylesetDeprecated()calls inConfiguration\Parser\Common.Checked with a fresh
ibexa:install ibexa-commerceon 4.6 (MySQL 8.0 and PostgreSQL 16): withdoctrine_migrations: trueall 25 migrations end up executed; withfalsethe legacy path runs and none are.Documentation:
The option to document is
ibexa.installer.doctrine_migrations(defaultfalse), replacingibexa.installer.schema_builder_event.enabled. When it'strue,ibexa:installinstalls the database schema and the core data by running the Ibexa-tagged Doctrine Migrations instead of dispatchingSchemaBuilderEvent; that needsibexa/doctrine-migrations. ibexa/documentation-developer#3337 doesn't mention either key yet.