client scope optimization doesn't work if all scope is dummy or unknown #78

Activity

1. catmando

   added

   bugSomething isn't workingSomething isn't working

   on Dec 6, 2018
2. catmando

   added this to the alpha1.3 milestone on Dec 7, 2018
3. catmando commented on Dec 7, 2018

   

   catmando

   on Dec 7, 2018

   Last edited by catmando

   ContributorAuthor

   More actions

   here is a failing test spec

   # hyper-model/spec/batch4/scope_spec.rb:315
     it 'the client filter will not be applied to unloaded scope' do
   
       isomorphic do
         TestModel.class_eval do
           scope :quicker, -> { where(completed: true) }, client: -> { completed }
         end
       end
   
       FactoryBot.create(:test_model, test_attribute: 'model-1', completed: false)
       FactoryBot.create(:test_model, test_attribute: 'model-2', completed: true)
       FactoryBot.create(:test_model, test_attribute: 'model-3', completed: false)
       FactoryBot.create(:test_model, test_attribute: 'model-4', completed: true)
   
       mount 'TestComponent2' do
         class TestComponent2 < HyperComponent
           class << self
             state_accessor :scope
           end
           before_mount do
             @render_count = 1
           end
           before_update do
             @render_count = @render_count + 1
           end
           render(DIV) do
             # render the all scope first, which will create a unloaded/dummy collection for all
             UL { TestModel.send(TestComponent2.scope || :all).each { |test_model| LI { test_model.test_attribute }}}
             # now get the count of the quicker (client side) scope, which must NOT use the dummy all collection as a base
             DIV { "quicker.count = #{TestModel.quicker.count}" }
           end
         end
       end
       page.should have_content('.count = 2')
       evaluate_ruby do
         TestComponent2.scope = :all
       end
       page.should have_content('model-2')
       page.should have_content('model-4')
       page.should_not have_content('model-1', wait: 0)
       page.should_not have_content('model-3', wait: 0)
     end
4. catmando commented on Dec 7, 2018

   

   catmando

   on Dec 7, 2018

   ContributorAuthor

   More actions

   note order is important if you move DIV { "quicker.count ... } first it works.
5. catmando commented on Dec 7, 2018

   

   catmando

   on Dec 7, 2018

   ContributorAuthor

   More actions

   it appears that adding the following guard to the beginning of sync_collection_with_parent does the trick:

   return if @parent.dummy_collection
6. catmando commented on Jan 15, 2019

   

   catmando

   on Jan 15, 2019

   ContributorAuthor

   More actions

   closed. for example see batch4/scope_spec.rb it 'the client filter will not be applied to unloaded scope but will be applied once the scope is loaded'
7. catmando

   added

   ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branchInternal Use Only: Has been fixed, specs passing and pushed to edge branch

   on Jan 15, 2019
8. catmando

   closed this as completedon Jan 17, 2019
9. mpantel

   added 2 commits that reference this issue on Sep 2, 2026

   gemspecs: a blank version selector must mean unset (hyperstack-org#78)

   ...

   3d535a2

   Merge branch 'fix/issue-78-version-selector' into 'edge'

   ...

   d3ff63b