Repository navigation
fix: preserve evaluation results when a verifier raises - #44
Open
Cookie0103 wants to merge 1 commit into
Open
Cookie0103 wants to merge 1 commit into
Cookie0103 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A verifier exception currently escapes after a successful agent execution and aborts
evaluate_skill. For example, afile_containscheck against a directory or a non-UTF-8 artifact prevents the remaining test cases and baseline phase from completing, and leaves that case withouttest_result.json.Catch ordinary exceptions at the per-case verification boundary. Record a failed
TestResultwith the exception type/message while retaining the completed agent output, token/turn counts and full statistics. Persist through the existing result path so sibling cases and baseline evaluation can finish. Ordinary assertion failures retainvalidation_result;BaseExceptioninterruption/cancellation still propagates. README documents the distinction.Validation:
BaseExceptionpropagation.Command descendant cleanup, subsequent verifiers within an errored case, and persistence-write recovery are unchanged.
AI assistance: implemented, tested and independently agent-reviewed with OpenAI Codex. The account owner authorized this contribution but has not personally reviewed or run these checks.