How do I add different responses based on request GET parameters? #285

Activity

1. basmaessen commented on Aug 20, 2018

   

   basmaessen

   on Aug 20, 2018

   More actions

   @AndrewSad Did you find any solution for this problem?

   😕React with 😕1Reacted by basmaessen
2. AndrewSad commented on Aug 20, 2018

   

   AndrewSad

   on Aug 20, 2018

   Author

   More actions

   @basmaessen yes, turned out it was quite easy

   🎉React with 🎉1Reacted by basmaessen
3. basmaessen commented on Aug 20, 2018

   

   basmaessen

   on Aug 20, 2018

   More actions

   @AndrewSad How did you do it?
4. AndrewSad commented on Aug 21, 2018

   

   AndrewSad

   on Aug 21, 2018

   Author

   More actions

   I've added this method to HTTPDynamicStubs class:

   typealias DynamicStubParameterTuple = (name: String, value: String)?
   
   func mapStub(url: String, filename: String, method: HTTPMethod = .GET, to parameter: DynamicStubParameterTuple = nil) {
           
           let response: ((HttpRequest) -> HttpResponse) = { [weak self] request in
               guard parameter != nil, request.queryParams.contains(where: { $0 == parameter! }) else {
                   return HttpResponse.notFound
               }
               let testBundle = Bundle(for: type(of: self!))
               let filePath = testBundle.path(forResource: filename, ofType: "json")
               let fileUrl = URL(fileURLWithPath: filePath!)
               let data = try! Data(contentsOf: fileUrl, options: .uncached)
               let json = self?.dataToJSON(data: data)
               return HttpResponse.ok(.json(json as AnyObject))
           }
           
           switch method  {
           case .GET : server.GET[url] = response
           case .POST: server.POST[url] = response
           }
       }

   Usage:

   self.dynamicStubs.mapStub(url: "<your url goes here>", filename: "<here goes filename>", method: .GET, to: (<parameter name>, <parameter value>))

   👍React with 👍4Reacted by Victor Sigler, Matt, Pelle Stenild Coltau and Vladimir Bebeshko
5. Vkt0r

   closed this as completedon Nov 4, 2018
6. andynovak12 commented on Feb 25, 2019

   

   andynovak12

   on Feb 25, 2019

   More actions

   @AndrewSad were you able to add 2 of the same urls that return different reponses based on the request parameters? I tried the above, and the second stub I setup overrides the previous one, and results in return HttpResponse.notFound when executing the first stub.
7. AndrewSad commented on Feb 25, 2019

   

   AndrewSad

   on Feb 25, 2019

   Last edited by AndrewSad

   Author

   More actions

   @andynovak12, actually I rewrote that piece since the time of my previous answer, will post solution in a bit
8. andynovak12 commented on Feb 25, 2019

   

   andynovak12

   on Feb 25, 2019

   More actions

   Thank you @AndrewSad ! I am looking forward to seeing it.
9. AndrewSad commented on Feb 26, 2019

   

   AndrewSad

   on Feb 26, 2019

   Last edited by AndrewSad

   Author

   More actions

   So, method now goes like this:

   func mapStub(url: String, to mappedData: MappedFilenameToParameter, method: HTTPMethod = .GET) {
           
           let response: ((HttpRequest) -> HttpResponse) = { [weak self] request in
               
               guard let filename = self?.findFile(for: request, in: mappedData) else {
                   return HttpResponse.notFound
               }
               
               let testBundle = Bundle(for: type(of: self!))
               let filePath = testBundle.path(forResource: filename, ofType: "json")
               let fileUrl = URL(fileURLWithPath: filePath!)
               let data = try! Data(contentsOf: fileUrl, options: .uncached)
               let json = self?.dataToJSON(data: data)
               return HttpResponse.ok(.json(json as AnyObject))
           }
           switch method  {
           case .GET : server.GET[url] = response
           case .POST: server.POST[url] = response
           }
       }

   New 'magic' inside this function:

   private func findFile(for request: HttpRequest, in map: MappedFilenameToParameter) -> String? {
           for param in request.queryParams {
               if let filename = map[DynamicStubParameter(name: param.0, value: param.1)]  {
                   return filename
               }
           }
           return nil
       }

   New typealias:

   struct DynamicStubParameter: Hashable {
       var name = ""
       var value = ""
   }
   
   typealias MappedFilenameToParameter = [DynamicStubParameter:String]

   And usage:

   let someValues = [
               DynamicStubParameter(name:"<Field here>", value: "<Value>" ) : "<filename first JSON>",
               DynamicStubParameter(name:"<Same field>", value: "<Another value>" ) : "<filename second JSON>",
           ]
           self.dynamicStubs.mapStub(url: "<your URL here>", to: someValues, method: .GET)

   Notice: someValues is the name for our array of DynamicStubParameter values.

   👍React with 👍1Reacted by Vladimir Bebeshko
10. andynovak12 commented on Feb 27, 2019

    

    andynovak12

    on Feb 27, 2019

    More actions

    Thanks so much for sharing @AndrewSad !
    This works for a request's body parameters as well, by replacing request.queryParams with String(bytes: request.body, encoding: .utf8)!, and handling if that String contains your required parameters.
11. AndrewSad commented on Feb 27, 2019

    

    AndrewSad

    on Feb 27, 2019

    Author

    More actions

    You are welcome ;) Got through a lot of pain back in the day to solve this.

    👍React with 👍2Reacted by Andy Novak and Rafael Schmitt