Skip to content

Breaking change not marked as breaking in changelog #700

Closed

Description

@Linuus

Hi!

I just upgraded the HTTPrb gem and had some issues. This PR #576 introduces a breaking change but it's not noted in the changelog as such (unless I'm missing something).
Previously, the headers were normalized when they were added so x-total-count would be stored as X-Total-Count. We then used response.to_a which returns [status, headers_as_hash, body]. Before this change, the hash keys were already normalized so when we did headers["X-Total-Count"] it worked. After this change though, it started returning nil since the hash keys didn't match anymore.

Perhaps we can update the changelog to avoid other people hitting the same issues as me? :)

Activity

  1. tarcieri commented on Nov 10, 2021

    @tarcieri
    Member

    Please open a PR to add it

  2. Linuus commented on Nov 10, 2021

    @Linuus
    ContributorAuthor

    Please open a PR to add it

    Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions