You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Breaking change not marked as breaking in changelog #700
I just upgraded the HTTPrb gem and had some issues. This PR #576 introduces a breaking change but it's not noted in the changelog as such (unless I'm missing something).
Previously, the headers were normalized when they were added so x-total-count would be stored as X-Total-Count. We then used response.to_a which returns [status, headers_as_hash, body]. Before this change, the hash keys were already normalized so when we did headers["X-Total-Count"] it worked. After this change though, it started returning nil since the hash keys didn't match anymore.
Perhaps we can update the changelog to avoid other people hitting the same issues as me? :)
Activity
tarcieri commentedon Nov 10, 2021
Please open a PR to add it
Linuus commentedon Nov 10, 2021
Done!