Repository navigation
undefined method 'wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00> #697
Description
5.0.3 version has just been released has been released. We have bumped the version of the gem automatically since that was a patch update and then experienced a NoMethodError
undefined method `wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00>
backtrace points to: /gems/http-5.0.3/lib/http/timeout/global.rb:38:
http/lib/http/timeout/global.rb
Line 38 in 66a3af2
There is a change in that line in a following PR: #691
However in another place in a similar case the method wait_readable is called on io object not directly on socket:
http/lib/http/timeout/global.rb
Lines 83 to 84 in 66a3af2
http/lib/http/timeout/global.rb
Lines 92 to 96 in 66a3af2
Activity
Fix `HTTP::Timeout::Global#connect_ssl`
tarcieri commentedon Oct 7, 2021
I believe this should do it: #698.
It's unfortunate that this case isn't covered by the test suite.
Fix `HTTP::Timeout::Global#connect_ssl` (#698)
tarcieri commentedon Oct 7, 2021
@lukasz-wojcik can you verify this fixes the problem? If it does, I can cut another release.
ollym commentedon Oct 7, 2021
@tarcieri we had the same issue and just deployed master branch and it's fixed, from our perspective you're good to cut a new release.
lukasz-wojcik commentedon Oct 7, 2021
From what I have checked the PR fixes this particular exception. Thx
tarcieri commentedon Oct 7, 2021
Released in v5.0.4