Repository navigation
Delegation issues in HTTP::Request::Caching #239
Description
While investigating jruby/jruby#3151, a few issues with the way Caching does delegation came to light:
- At least one place, in
conditional_on_changes_to, anHTTP::Requestobject gets double-delegated. Both theself.class.newand.cachingcalls wrap the newHTTP::Requestobject in a delegatingCachinginstance. - The
Cachingclass itself is created beforeHTTP::Requesthas completed loading, resulting in aDelegateClassthat does most delegation throughmethod_missingrather than through generated, direct delegation methods.
These issues are not strictly bugs, but they likely affect performance. In the case of jruby/jruby#3151, they also exposed an obscure bug in JRuby.
Activity
tarcieri commentedon Jul 21, 2015
I'm not really happy with the quality of the caching code. It's caused a lot of sporadic test failures. Having a dependency on rack isn't really something I like either.
Perhaps we could remove it and add it back when/if it's in a better state?
zanker commentedon Jul 21, 2015
I agree with removing the code until something better is done.
ixti commentedon Jul 21, 2015
👍 for wiping it out.
Revert Caching (#177) (fixes #239)
tarcieri commentedon Jul 22, 2015
Created #240 to revert caching
Merge pull request #240 from httprb/tarcieri/revert-caching