Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #405

Activity

1. serhiy-storchaka commented on Dec 20, 2018

   

   serhiy-storchaka

   on Dec 20, 2018

   More actions

   This is a blocker for CPython: python/cpython#10596.
2. tirkarthi commented on Dec 20, 2018

   

   tirkarthi

   on Dec 20, 2018

   More actions

   Seems to be a duplicate of #402 ?
3. labrys commented on Dec 22, 2018

   

   labrys

   on Dec 22, 2018

   Last edited by labrys

   Author

   More actions

   @tirkarthi Not a duplicate as the issue still exists after #402 was closed.
   from collections import ... is still used in the following locations:

   • html5lib._tokenizer
   • html5lib.html5parser
   • html5lib.filters.alphabeticalattributes
   • html5lib.tests.test_alphabeticalattributes
   • html5lib.treewalkers.etree
4. tirkarthi commented on Dec 22, 2018

   

   tirkarthi

   on Dec 22, 2018

   More actions

   The actual warning is about importing ABCs using from collections instead of collections.abc . OrderedDict and deque can still be imported from collections. from collections import ... is going away only for ABCs. The linked PR blocking CPython is about ABCs and a quick scan of the listed files tells me this is fixed in html5lib.
5. labrys commented on Dec 22, 2018

   

   labrys

   on Dec 22, 2018

   Author

   More actions

   @tirkarthi you are correct... closing this
6. labrys

   closed this as completedon Dec 22, 2018