Repository navigation
fix(query): harden query_arrow follow and non-Arrow 200 - #241
Merged
Merged
Conversation
- Enforce max_auto_bytes when a large result is read from the Results API, on the size of the Arrow data; the row guard alone does not bound memory. - A 200 that is not Arrow raises ApiException with the response body kept, instead of a decode error, so the run id of a query that ran is not lost.
eddietejeda
requested review from
shefeek-jinnah
and removed request for
a team
November 19, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two fixes from the review of the same helper in the Rust SDK (hotdata-dev/sdk-rust#189).
query_arrowreads a large result from the Results API, it now enforcesmax_auto_bytes(instance default or per-call) as well asmax_auto_rows, measured on the Arrow data. The row guard alone does not bound memory when rows are wide. Past the guard it raisesResultTooLargeError(kind="bytes").query_arrowraisesApiExceptionwith the response body kept, instead of an Arrow decode error. The query ran, so the run id must not be lost. It is not retried.Behaviour change: a followed result over the default 64 MiB byte guard now raises unless the caller raises
max_auto_bytesor sets it toNone.queryalready behaves this way for JSON.Unit tests cover both. The integration suite and a live large-result run pass.