You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cache: temporary cache directories are never removed #97
Found by a memory-accounting audit of 8b3c813. The tests are on branch audit/memory-tests and fail on main today; check out that branch to run them. File and line links point at that commit.
What goes wrong. When no store is given, build() creates tempfile::tempdir().unwrap().keep() (src/core/src/cache/builders.rs:138) and never deletes it. The server does the same (src/datafusion-server/src/lib.rs:141). Each leaked directory holds a t4 file that can grow up to the disk budget.
Evidence. The temporary directory outlived the cache, still containing a 4,096-byte liquid_cache.t4. The server behaves the same.
cargo +1.96.0 test -p liquid-cache-datafusion-server --lib audit_service_temp_dir_is_removed_on_drop -- --nocapture
Flags: P probabilistic (a pass after a fix only means the race wasn't hit), F interleaving forced by a test hook, L Linux only, D needs Docker, M measurement only, C control (passes by design).
Activity